Re: [PATCH] Fix fetch completeness assumptions
- From
Junio C Hamano <junkio@cox.net>
- Date
- Sep 16, 2005, 06:04 UTC
- Message-ID
- <7vslw5tuob.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.63.0509151243020.23242@iabervon.org>
Daniel Barkalow <barkalow@iabervon.org> writes:
> Yup. I think I want to untangle some of the functions in commit.c, though, > because it wasn't sufficiently clear to me how those functions worked for > me to actually use the right one.
Sorry, *_gently was my fault. The version without _gently was there first, which issued its own complaints when it was fed a non commit -- I presume that was OK for the purpose of whoever wrote it first, but was not very useful when the caller wanted to do its own "oh, if it is not a commit then I'll do this other thing then" decision.