git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix fetch completeness assumptions

From
Junio C Hamano <junkio@cox.net>
Date
Sep 15, 2005, 08:09 UTC
Message-ID
<7vd5naah1m.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.63.0509142120020.23242@iabervon.org>
Daniel Barkalow <barkalow@iabervon.org> writes:
Show 10 quoted lines
> Don't assume that any commit we have is complete; assume that any ref
> we have is complete.
>
> Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
>
> ---
> Only lightly tested, but it seems to work. Marks all of the commits in 
> refs, and their ancestors back as far as the date of the commit it's 
> processing. If the commit it's processing is marked, it doesn't recurse 
> into it.

First I thought you were using the date for the cutting-off decision and was going to object to the patch because of it, but re-reading the code made me realize that you are using date only to better the heuristics that limits how many commits reachable from existing refs we would tangle to see if the newly seen commit is reachable from our refs -- the logic looks correct.

The "complete" commit_list is a clever piece of code; I like it.
Previous: Daniel BarkalowNext: Daniel Barkalow
Message 2 of 11 in “Fix fetch completeness assumptions”
  1. Fix fetch completeness assumptionsDaniel Barkalow, Sep 15, 2005
  2. Junio C HamanoSep 15, 2005
  3. Daniel BarkalowSep 15, 2005
  4. Sergey VlasovSep 15, 2005
  5. Daniel BarkalowSep 15, 2005
  6. Junio C HamanoSep 16, 2005
  7. Junio C HamanoSep 17, 2005
  8. Junio C HamanoSep 17, 2005
  9. Help cloning over http.Junio C Hamano, Sep 17, 2005
  10. Daniel BarkalowSep 17, 2005
  11. Improve the safety check used in fetch.cJunio C Hamano, Sep 18, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.