Re: [PATCH] git-rev-list(1): group options; reformat; document more options

From: Junio C Hamano <junkio@cox.net>
Date: Sep 1, 2006, 00:06 UTC
Message-ID: <7vsljc78m9.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0608311611440.27779@g5.osdl.org>

Linus Torvalds <torvalds@osdl.org> writes:

Show 16 quoted lines

> On Fri, 1 Sep 2006, Jonas Fonseca wrote:
>> Linus Torvalds <torvalds@osdl.org> wrote Thu, Aug 31, 2006:
>> > 
>> > Umm? You should get a "usage" error, no?
>> 
>> Yes, ok, they do not seem to make sense for git-rev-list, however if you
>> pass either to git-log, the output seems to make room for a diff, adding
>> one extra newline, but without appending any diff.
>
> Ahh. I think that a "-r" without any other request for patches (or 
> "--name-status" or similar) should probably imply "--raw". At least that 
> was how it historically worked..
>
> Anyway, _if_ it ever worked (and I think it did, but I'm way too lazy to 
> bother checking), this may have been broken by the extensive diff option 
> cleanups by Timo in June. Timo? Junio?

I think it did too. I am kind of surprised that nobody noticed and t4013 test (which was done specifically to catch potential behaviour change by Timo's patch) did not check for this particular case.