git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix handle leak in write_tree

From
Junio C Hamano <junkio@cox.net>
Date
Apr 25, 2007, 21:16 UTC
Message-ID
<7vslaoupbp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20070425205930.GF30061@steel.home>
Alex Riesen <raa.lkml@gmail.com> writes:
Show 9 quoted lines
> Then let the top level call something like
>
>     git_cleanup(struct git_context *);
>
> in its _own_ signal or atexit handlers. If it didn't setup the
> handlers, than perhaps it did want it so (leaving tempfiles behind is
> sometimes done on purpose). Or it _is_ a bug, but then it is clear:
> you have to cleanup, and you do git's part of cleanup with
> git_cleanup.

I would agree that libification would need to go something along that line.

In the meantime for 1.5.2 stabilization, let's do the minimum fix of applying your earlier patch.

Previous: Alex RiesenNext: Alex Riesen
Message 6 of 7 in “Fix handle leak in write_tree”
  1. Fix handle leak in write_treeAlex Riesen, Apr 23, 2007
  2. Junio C HamanoApr 24, 2007
  3. Alex RiesenApr 24, 2007
  4. Junio C HamanoApr 24, 2007
  5. Alex RiesenApr 25, 2007
  6. Junio C HamanoApr 25, 2007
  7. Fix handle leak in write_treeAlex Riesen, Apr 25, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.