From: Junio C Hamano <junkio@cox.net>
Date: Wed, 25 Apr 2007 21:16:58 GMT
Subject: Re: [PATCH] Fix handle leak in write_tree
Message-ID: <7vslaoupbp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070425205930.GF30061@steel.home>

Alex Riesen <raa.lkml@gmail.com> writes:

> Then let the top level call something like
>
>     git_cleanup(struct git_context *);
>
> in its _own_ signal or atexit handlers. If it didn't setup the
> handlers, than perhaps it did want it so (leaving tempfiles behind is
> sometimes done on purpose). Or it _is_ a bug, but then it is clear:
> you have to cleanup, and you do git's part of cleanup with
> git_cleanup.

I would agree that libification would need to go something along
that line.

In the meantime for 1.5.2 stabilization, let's do the minimum
fix of applying your earlier patch.