Re: [PATCH 05/16] unpack-trees.c: verify_uptodate: remove dead code

From: Junio C Hamano <junkio@cox.net>
Date: May 18, 2007, 22:33 UTC
Message-ID: <7vsl9t4va0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11795163061911-git-send-email-skimo@liacs.nl>

skimo@liacs.nl writes:

Show 26 quoted lines

> From: Sven Verdoolaege <skimo@kotnet.org>
>
> This code was killed by commit fcc387db9bc453dc7e07a262873481af2ee9e5c8.
>
> Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>
> ---
>  unpack-trees.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/unpack-trees.c b/unpack-trees.c
> index 906ce69..cac2411 100644
> --- a/unpack-trees.c
> +++ b/unpack-trees.c
> @@ -414,10 +414,6 @@ static void verify_uptodate(struct cache_entry *ce,
>  			return;
>  		errno = 0;
>  	}
> -	if (o->reset) {
> -		ce->ce_flags |= htons(CE_UPDATE);
> -		return;
> -	}
>  	if (errno == ENOENT)
>  		return;
>  	die("Entry '%s' not uptodate. Cannot merge.", ce->name);
> -- 
> 1.5.2.rc3.783.gc7476-dirty

Hmmm.

I am not absolutely sure if the fcc387db change was correct anymore, but in any case, this removal of dead code should not break anything.

But this does not belong to your series either.

Perhaps I should apply this to 'master' regardless of the rest of the series.