Re: [PATCH 09/16] entry.c: optionally checkout submodules

From: Alex Riesen <raa.lkml@gmail.com>
Date: May 18, 2007, 22:33 UTC
Message-ID: <20070518223338.GF10475@steel.home>
In-Reply-To: <20070518220323.GL942MdfPADPa@greensroom.kotnet.org>

Sven Verdoolaege, Sat, May 19, 2007 00:03:23 +0200:

Show 12 quoted lines

> On Fri, May 18, 2007 at 11:56:42PM +0200, Alex Riesen wrote:
> > skimo@liacs.nl, Fri, May 18, 2007 21:24:58 +0200:
> > > +	if (err)
> > > +		return error("failed to run git-checkout in submodule '%s'", path);
> > 
> > We may need an option to ignore these failures. Maybe even active by
> > default. Imagine a superproject with _optional_ submodules, where it
> > is just nice to know that some submodules weren't checked out. BTW,
> > doesn't git-checkout already prints an error?
> 
> Probably.  You probably noticed that I haven't written any tests yet...
>

I see. It was a very ... provocative patch series :)

> Still, the error that git-checkout prints may not give enough of a clue
> that something was wrong with a submodule.

Like, for example, it failed because the directory is not a git repo yet, because the previous git-checkout was called _without_ --submodule and the directories created are just empty.

Anyway, just a "failed to run git-checkout" is not very helpful either. Come to think about it, there is not very much you can tell out of super-project context. git-checkout will always know better.