git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix an unitialized pointer in merge-recursive.c

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 16, 2007, 08:08 UTC
Message-ID
<7vsl6jkila.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<e5bfff550708160100t5aa93430x6cbe83e6e7a61d73@mail.gmail.com>
"Marco Costalba" <mcostalba@gmail.com> writes:
Show 5 quoted lines
> Indeed &mrtree is passed to merge_trees() that not always
> seems to set the value, so on some paths mrtree could
> return uninitialized.
>
> Spotted by a gcc 4.2.1 warning
Are you sure that gcc is correctly seeing the codeflow?

In merge(), mrtree is used only under index_only, and merge_trees() always sets *result under index_only.

Previous: Marco CostalbaNext: Marco Costalba
Message 2 of 7 in “Fix an unitialized pointer in merge-recursive.c”
  1. Fix an unitialized pointer in merge-recursive.cMarco Costalba, Aug 16, 2007
  2. Junio C HamanoAug 16, 2007
  3. Marco CostalbaAug 16, 2007
  4. Junio C HamanoAug 16, 2007
  5. Junio C HamanoAug 16, 2007
  6. David KastrupAug 16, 2007
  7. Florian WeimerAug 16, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.