Re: [PATCH] Fix an unitialized pointer in merge-recursive.c

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 16, 2007, 08:23 UTC
Message-ID: <7vodh7khuo.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <e5bfff550708160111n66b5ea94k26cf2fecc06fd84c@mail.gmail.com>

"Marco Costalba" <mcostalba@gmail.com> writes:

Show 22 quoted lines

> On 8/16/07, Junio C Hamano <gitster@pobox.com> wrote:
>> "Marco Costalba" <mcostalba@gmail.com> writes:
>>
>> > Indeed &mrtree is passed to merge_trees() that not always
>> > seems to set the value, so on some paths mrtree could
>> > return uninitialized.
>> >
>> > Spotted by a gcc 4.2.1 warning
>>
>> Are you sure that gcc is correctly seeing the codeflow?
>>
>> In merge(), mrtree is used only under index_only, and
>> merge_trees() always sets *result under index_only.
>>
>
> Ok ;-)
>
> Now two options:
>
> - discard the patch
>
> - change the title in 'silence a gcc bougus warning'

Third option. Change the assignment from "mrtree = NULL" to "mrtree = mtree". It is a standard idiom to work around stupid gcc warnings.