Re: [PATCH 2/3] rev-list: Introduce --no-output to avoid /dev/null redirects

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 9, 2007, 08:58 UTC
Message-ID: <7vsl3fvlrb.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071109081204.GB2794@steel.home>

Alex Riesen <raa.lkml@gmail.com> writes:

Show 19 quoted lines

> Junio C Hamano, Fri, Nov 09, 2007 08:32:01 +0100:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>> 
>> > @@ -640,7 +656,9 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
>> >  		}
>> >  	}
>> >  
>> > -	traverse_commit_list(&revs, show_commit, show_object);
>> > +	traverse_commit_list(&revs,
>> > +		nooutput ? noshow_commit : show_commit,
>> > +		nooutput ? noshow_object : show_object);
>> >  
>> >  	return 0;
>> >  }
>> 
>> The function names noshow_xxx() looked a bit funny, but I do not
>> offhand have better alternatives to offer.
>
> "hide", "skip", "ignore"?

But look at what the functions do. The original show_xxx() was to print and then process. Shawn splitted them into show_xxx() and noshow_xxx(), leaft the printing part in the former, made the former call the latter at the end, and moved the processing to the latter. So it is not any of the three words.