Re: [PATCH 2/3] rev-list: Introduce --no-output to avoid /dev/null redirects

From: Junio C Hamano <junio@pobox.com>
Date: Nov 9, 2007, 07:32 UTC
Message-ID: <7vejezx4b2.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071108080052.GB16690@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

Show 11 quoted lines

> @@ -640,7 +656,9 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
>  		}
>  	}
>  
> -	traverse_commit_list(&revs, show_commit, show_object);
> +	traverse_commit_list(&revs,
> +		nooutput ? noshow_commit : show_commit,
> +		nooutput ? noshow_object : show_object);
>  
>  	return 0;
>  }

The function names noshow_xxx() looked a bit funny, but I do not offhand have better alternatives to offer.

This allows "--bisect-vars --no-output" and "--bisect-all --bisect-vars --no-output" but makes them behave differently. I do not think --no-output is useful with bisection anyway but maybe it makes sense to forbid the combination?