Re: Applying patches from gmane can be dangerous.

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 7, 2008, 08:21 UTC
Message-ID: <7vsl05p46n.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <ve51w5yb.fsf@blue.sea.net>

Jari Aalto <jari.aalto@cante.net> writes:

Show 12 quoted lines

> FYI,
>
> Emacs Gnus + news.gmane.org gives access to raw articles with single
> command. Suppose cursor is at thread start "!"
>
> ! R. [  40: Junio C Hamano         ] Applying patches from gmane can be dangerous.
>   R.     [  19: Nicolas Pitre          ]
>
>
> Pressing "C-u g" will display the unmodified article as seen by mail
> transport. Running git's apply command can be automated pretty easily
> from there.

I do not think Gnus demiming (that C-u g helps us with) is not an issue.

Have you tried to look at the article in question? Inside your Gnus + news.gmane.org, try typing this:

	j 7 2 6 9 9 <Enter> C-u g

The last two keystrokes are your "C-u g".

And look at the second line in the buffer, that says:

    From: Brian Downing <bdowning-oU/tDdhfGLReoWH0uzbU5w@public.gmane.org>

and weep X-<.

Then scroll down to find Signed-off-by: lines that are similarly mangled, and weep more.

Maybe you run a much newer Gnus, and Lars taught "C-u g" to unmangle them. After all, gmane and Gnus are both his creations, so it _is_ possible. But somehow I doubt it.

If there weren't gmane address mangling, a quickest way to apply a gmane patch to commit is:

	C-u g | g i t  a m - 3 - s <Enter>

	For Gnus uninitiated, it reads: show as raw as opposed
	to demimed (C-u g), pipe the article to the shell
	command (|) that is "git am -3 -s".

But I usually work in batches, so I first C-o (write to file) the articles to a separate mbox, review and _edit_ them as needed before running "git am". And C-o does not suffer from Gnus demiming, so C-u g is not useful in my workflow.