git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Applying patches from gmane can be dangerous.

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 7, 2008, 04:14 UTC
Message-ID
<7vodatqu6w.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080205211044.GP26392@lavos.net>

I picked up the qsort patch from Brian while reading the list via gmane's newsfeed and applied it without realizing that it was one of the articles whose addresses on all the address header fields _and_ all strings that look like e-mail addresses have been mangled by gmane. Sign-offs by Dscho and Steffen Prohaska have also been munged (even though that are not part of headers).

It already is part of 'next', and we have the policy of not rewinding 'next', so the record of this mistake will unfortunately be with us forever. Sorry, Brian, Dscho and Steffen.

For the curious, the message was:
    http://article.gmane.org/gmane.comp.version-control.git/72699/raw

I've added the following in my .git/hooks/applypatch-msg and made it executable, so hopefully it won't happen again.

    #!/bin/sh
    case "$GIT_AUTHOR_EMAIL" in
    *@public.gmane.org)
            echo >&2 "Gmane munged the author's email address, aborting."
            echo >&2 "Pick up the original message from your mbox!"
            exit 1
            ;;
    esac

This is really sad. gmane gives us a clean threaded interface (both in web and newsreader), and it never forgets. Whenever I need to refer somebody to an old discussion, I can give an URL to it and allmost all the discussion messages are there with a single paste and clicking around. It has been an indispensable service to me ever since I started reading the git list with it. It is really a shame that I have to prevent picking up patch messages from it with the above hook.

I am wondering if other development communities had a similar issue already, and if so how they are dealing with it.

Previous: Brian DowningNext: Nicolas Pitre
Message 2 of 17 in “compat: Add simplified merge sort implementation from glibc”
  1. compat: Add simplified merge sort implementation from glibcBrian Downing, Feb 5, 2008
  2. Applying patches from gmane can be dangerous.Junio C Hamano, Feb 7, 2008
  3. Nicolas PitreFeb 7, 2008
  4. Junio C HamanoFeb 7, 2008
  5. 'next' will be rewound and rebuilt after feature releases.Junio C Hamano, Feb 10, 2008
  6. Jari AaltoFeb 7, 2008
  7. Junio C HamanoFeb 7, 2008
  8. Mike HommeyFeb 7, 2008
  9. Johannes SchindelinFeb 7, 2008
  10. Brian DowningFeb 7, 2008
  11. Aidan Van DykFeb 7, 2008
  12. Brian DowningFeb 7, 2008
  13. Johannes SchindelinFeb 7, 2008
  14. Johannes SchindelinFeb 11, 2008
  15. Frank LichtenheldFeb 7, 2008
  16. Johannes SchindelinFeb 5, 2008
  17. Brian DowningFeb 6, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.