git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] compat/cygwin.c - Use cygwin's stat if core.filemode == true

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 12, 2008, 19:35 UTC
Message-ID
<7vskr1fvys.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<1223837086-2864-1-git-send-email-mlevedahl@gmail.com>
Mark Levedahl <mlevedahl@gmail.com> writes:
Show 10 quoted lines
> Cygwin's POSIX emulation allows use of core.filemode true, unlike native
> Window's implementation of stat / lstat, and Cygwin/git users who have
> configured core.filemode true in various repositories will be very
> unpleasantly surprised to find that git is no longer honoring that option.
> So, this patch forces use of Cygwin's stat functions if core.filemode is
> set true, regardless of any other considerations.
>
> Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
> ---
> Updated to use trust_executable_bit as suggested on the list.

Before you do that, can you explain why git_cygwin_config() should duplicate the setting of that variable instead of using the existing parser for that variable by calling git_default_config()?

Previous: Mark LevedahlNext: Mark Levedahl
Message 7 of 11 in “compat/cygwin.c - Use cygwin's stat if core.filemode == true”
  1. compat/cygwin.c - Use cygwin's stat if core.filemode == trueMark Levedahl, Oct 11, 2008
  2. compat/cygwin.c - Use cygwin's stat if core.filemode == trueMark Levedahl, Oct 11, 2008
  3. Junio C HamanoOct 11, 2008
  4. compat/cygwin.c - Use cygwin's stat if core.filemode == trueMark Levedahl, Oct 11, 2008
  5. Dmitry PotapovOct 12, 2008
  6. compat/cygwin.c - Use cygwin's stat if core.filemode == trueMark Levedahl, Oct 12, 2008
  7. Junio C HamanoOct 12, 2008
  8. Mark LevedahlOct 12, 2008
  9. Junio C HamanoOct 12, 2008
  10. Mark LevedahlOct 13, 2008
  11. compat/cygwin.c - Use cygwin's stat if core.filemode == trueMark Levedahl, Oct 13, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.