From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 12 Oct 2008 19:35:07 GMT
Subject: Re: [PATCH] compat/cygwin.c - Use cygwin's stat if core.filemode == true
Message-ID: <7vskr1fvys.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1223837086-2864-1-git-send-email-mlevedahl@gmail.com>

Mark Levedahl <mlevedahl@gmail.com> writes:

> Cygwin's POSIX emulation allows use of core.filemode true, unlike native
> Window's implementation of stat / lstat, and Cygwin/git users who have
> configured core.filemode true in various repositories will be very
> unpleasantly surprised to find that git is no longer honoring that option.
> So, this patch forces use of Cygwin's stat functions if core.filemode is
> set true, regardless of any other considerations.
>
> Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
> ---
> Updated to use trust_executable_bit as suggested on the list.

Before you do that, can you explain why git_cygwin_config() should
duplicate the setting of that variable instead of using the existing
parser for that variable by calling git_default_config()?