Re: [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 14, 2009, 11:33 UTC
Message-ID: <7vsknm2kbs.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LSU.2.00.0901141148130.16109@fbirervta.pbzchgretzou.qr>

Jan Engelhardt <jengelh@medozas.de> writes:

Show 6 quoted lines

> parent v1.6.1
>
> git-daemon: use getnameinfo to resolve hostname
>
> This is much shorter than inet_ntop'ing, and also translated
> unresolvable addresses into a string.

translated? (I think you meant "translates" but my English is bad, so I am double checking).

This indeed is much nicer, provided if it is available at least as widely as inet_ntop() is.

We seem to ship inet_ntop() in compat/; a few questions.

 (1) Do we need similar compat/ function for getnameinfo()?  I am guessing
     that most likely places are the ones that need NO_INET_NTOP and
     NO_INET_PTON, and googling seems to indicate old Cygwin and HP-UX
     11.00 may be among them.

 (2) Do we still use inet_ntop() elsewhere, and if not, can we remove the
     compat/ definitions?