Re: [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname

From: Adeodato Simó <dato@net.com.org.es>
Date: Jan 14, 2009, 14:17 UTC
Message-ID: <20090114141723.GA6984@chistera.yi.org>
In-Reply-To: <20090114122536.GA5939@coredump.intra.peff.net>

* Jeff King [Wed, 14 Jan 2009 07:25:36 -0500]:

> On Wed, Jan 14, 2009 at 11:48:38AM +0100, Jan Engelhardt wrote:

> > This is much shorter than inet_ntop'ing, and also translated
> > unresolvable addresses into a string.

> Er, doesn't this totally change the meaning of REMOTE_ADDR from an IP
> address to a hostname?

Yes, I believe so.

However, AFAIK you can obtain the intended behavior if you pass NI_NUMERICHOST as a flag to the getnameinfo() call. With that, this patch can be still considered for inclusing if the original "don't hardcode protocol-specific bits" is still deemed worthy.

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
- Why are you whispering?
- Because I just think that no matter where she is, my mom can hear this
  conversation.
                -- Rory and Lane