Re: [PATCH v3] send-email: add --confirm option and configuration setting
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 3, 2009, 06:53 UTC
- Message-ID
- <7vsklvgkrx.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1236055938-65407-1-git-send-email-jaysoffian@gmail.com>
Jay Soffian <jaysoffian@gmail.com> writes:
Show 8 quoted lines
> There is a slight fib in message informing the user of the
> sendemail.confirm setting and this is intentional. Setting 'auto'
> differs from leaving sendemail.confirm unset in two ways: 1) 'auto'
> obviously squelches the informational message; 2) 'auto' prompts when
> the Cc list has been expanded even in the presence of a --suppress
> related option, where leaving sendemail.confirm unset does not. This is
> intentional to keep the message simple, and to avoid adding another
> sendemail.confirm value ('auto-except-suppress'?).I suspect you may get bug reports and refinement patches on top of this to fix the last issue up, but I think that better should happen once the base patch is in-tree.
Let's queue this to 'pu' and see how people react.
Thanks.