Re: [PATCH v3] send-email: add --confirm option and configuration setting
- From
Jay Soffian <jaysoffian@gmail.com>
- Date
- Mar 3, 2009, 16:22 UTC
- Message-ID
- <76718490903030822j690cb97blea292d391c0d0112@mail.gmail.com>
- In-Reply-To
- <36ca99e90903030354j33de0313n41d8a95ff898798b@mail.gmail.com>
On Tue, Mar 3, 2009 at 6:54 AM, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
Show 11 quoted lines
> On Tue, Mar 3, 2009 at 05:52, Jay Soffian <jaysoffian@gmail.com> wrote:
>> diff --git a/git-send-email.perl b/git-send-email.perl
>> index adf7ecb..57127aa 100755
>> --- a/git-send-email.perl
>> +++ b/git-send-email.perl
>> @@ -837,6 +837,37 @@ X-Mailer: git-send-email $gitversion
>> unshift (@sendmail_parameters,
>> '-f', $raw_from) if(defined $envelope_sender);
>>
>> + if ($needs_confirm && !$dry_run) {
> So, the output is now differnt with and without --dry-run?There doesn't seem to be any point in having the user confirm before sending the message if the message is not actually going to be sent. Am I missing something?
j.