git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2] Add --reference option to git submodule.

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 28, 2009, 18:52 UTC
Message-ID
<7vskjslig6.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<49F702C0.8030206@drmicha.warpmail.net>
Michael J Gruber <git@drmicha.warpmail.net> writes:
Show 10 quoted lines
> Michael S. Tsirkin venit, vidit, dixit 28.04.2009 14:30:
>> This adds --reference option to git submodule add and
>> git submodule update commands, which is passed on to git clone.
>> 
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>> 
>> Here's v2. Ack?
>
> I don't think it's up to me to Ack but you addressed my remarks.
You can certainly say "Reviewed-by: me" and/or "Tested-by: me".
> BTW, even dash has "test STRING" so portability doesn't require -n but I
> think it's OK either way.
It always is a good discipline and style.
Previous: Michael J GruberNext: Michael S. Tsirkin
Message 5 of 6 in “[PATCHv2] Add --reference option to git submodule.”
  1. Michael S. TsirkinApr 28, 2009
  2. Michael J GruberApr 28, 2009
  3. Johannes SixtApr 28, 2009
  4. Michael J GruberApr 28, 2009
  5. Junio C HamanoApr 28, 2009
  6. Michael S. TsirkinMay 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.