From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 28 Apr 2009 18:52:09 GMT
Subject: Re: [PATCHv2] Add --reference option to git submodule.
Message-ID: <7vskjslig6.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <49F702C0.8030206@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

> Michael S. Tsirkin venit, vidit, dixit 28.04.2009 14:30:
>> This adds --reference option to git submodule add and
>> git submodule update commands, which is passed on to git clone.
>> 
>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> ---
>> 
>> Here's v2. Ack?
>
> I don't think it's up to me to Ack but you addressed my remarks.

You can certainly say "Reviewed-by: me" and/or "Tested-by: me".

> BTW, even dash has "test STRING" so portability doesn't require -n but I
> think it's OK either way.

It always is a good discipline and style.