git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH next] t7407: use 'cut' utility rather than bash's substring expansion notation

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 20, 2009, 07:34 UTC
Message-ID
<7vskfnq6q5.fsf@alter.siamese.dyndns.org>
In-Reply-To
<200908200856.30359.johan@herland.net>
Johan Herland <johan@herland.net> writes:
Show 14 quoted lines
>> - $sub1sha1 sub1 (${sub1sha1:0:7})
>> - $sub2sha1 sub2 (${sub1sha1:0:7})
>> + $sub1sha1 sub1 ($(echo $sub1sha1 | cut -c 1-7))
>> + $sub2sha1 sub2 ($(echo $sub1sha1 | cut -c 1-7))
>
> Typo (both in the original, and the patch), should be:
> 	$sub2sha1 sub2 ($(echo $sub2sha1 | cut -c 1-7))
>
>>   $sub3sha1 sub3 (heads/master)
>>  EOF
>
> Otherwise:
>
> Acked-by: Johan Herland <johan@herland.net>

Hmm, what does the command use to shorten these object names? It may be safer and more correct to use "rev-parse --short" in case these object names were ambigous in their first 7 hexdigits.

Previous: Johan HerlandNext: Johan Herland
Message 3 of 5 in “t7407: use 'cut' utility rather than bash's substring expansion notation”
  1. t7407: use 'cut' utility rather than bash's substring expansion notationBrandon Casey, Aug 20, 2009
  2. Johan HerlandAug 20, 2009
  3. Junio C HamanoAug 20, 2009
  4. Johan HerlandAug 20, 2009
  5. Brandon CaseyAug 20, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.