From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 20 Aug 2009 07:34:10 GMT
Subject: Re: [PATCH next] t7407: use 'cut' utility rather than bash's substring expansion notation
Message-ID: <7vskfnq6q5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <200908200856.30359.johan@herland.net>

Johan Herland <johan@herland.net> writes:

>> - $sub1sha1 sub1 (${sub1sha1:0:7})
>> - $sub2sha1 sub2 (${sub1sha1:0:7})
>> + $sub1sha1 sub1 ($(echo $sub1sha1 | cut -c 1-7))
>> + $sub2sha1 sub2 ($(echo $sub1sha1 | cut -c 1-7))
>
> Typo (both in the original, and the patch), should be:
> 	$sub2sha1 sub2 ($(echo $sub2sha1 | cut -c 1-7))
>
>>   $sub3sha1 sub3 (heads/master)
>>  EOF
>
> Otherwise:
>
> Acked-by: Johan Herland <johan@herland.net>

Hmm, what does the command use to shorten these object names?  It may be
safer and more correct to use "rev-parse --short" in case these object
names were ambigous in their first 7 hexdigits.