git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Global .git directory

From
Junio C Hamano <gitster@pobox.com>
Date
May 4, 2010, 16:55 UTC
Message-ID
<7vsk67mwse.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20100504054040.GC13139@goomba>
Andrew Ruder <andy@aeruder.net> writes:
> I'm not really a person that will be doing the reviewing but as a
> frequent lurker on the list, I'm going to try to help you out some.
Thanks.
> While you're not exactly fixing a bug, this would benefit from a
> testcase.

Just so that people do not misunderstand. A test is _not_ about proving that your patch fixed a bug. It instead is to protect your change from future breakages by _other people_.

Having a test that would fail if careless others muck with related codepath in the future without taking your change into account is a good way to make sure your new feature or your good change of behaviour keep working (the alternative is for you as the author of such a valuable change to stay on the list 24/7, audit all the patches that may negatively affect your change and veto them before they are applied, which is impractical for most people).

Previous: Gerhard WiesingerNext: Jacob Helwig
Message 16 of 17 in “Global .git directory”
  1. Gerhard WiesingerApr 27, 2010
  2. Thomas RastApr 27, 2010
  3. Gerhard WiesingerApr 27, 2010
  4. Erik Faye-LundApr 27, 2010
  5. Gerhard WiesingerApr 28, 2010
  6. Tomas CarneckyApr 28, 2010
  7. Gerhard WiesingerApr 28, 2010
  8. Alex RiesenApr 28, 2010
  9. Gerhard WiesingerApr 28, 2010
  10. Erik Faye-LundApr 28, 2010
  11. Gerhard WiesingerApr 28, 2010
  12. Gerhard WiesingerMay 4, 2010
  13. Andrew RuderMay 4, 2010
  14. Andreas EricssonMay 4, 2010
  15. Gerhard WiesingerMay 4, 2010
  16. Junio C HamanoMay 4, 2010
  17. Jacob HelwigApr 27, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.