From: Junio C Hamano Date: Tue, 04 May 2010 16:55:29 GMT Subject: Re: Global .git directory Message-ID: <7vsk67mwse.fsf@alter.siamese.dyndns.org> In-Reply-To: <20100504054040.GC13139@goomba> Andrew Ruder writes: > I'm not really a person that will be doing the reviewing but as a > frequent lurker on the list, I'm going to try to help you out some. Thanks. > While you're not exactly fixing a bug, this would benefit from a > testcase. Just so that people do not misunderstand. A test is _not_ about proving that your patch fixed a bug. It instead is to protect your change from future breakages by _other people_. Having a test that would fail if careless others muck with related codepath in the future without taking your change into account is a good way to make sure your new feature or your good change of behaviour keep working (the alternative is for you as the author of such a valuable change to stay on the list 24/7, audit all the patches that may negatively affect your change and veto them before they are applied, which is impractical for most people).