git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-p4: correct indenting and formatting

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 12, 2011, 08:45 UTC
Message-ID
<7vsjwy33zn.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1294808703-1848-1-git-send-email-andrew@andrewgarber.com>
Andrew Garber <andrew@andrewgarber.com> writes:
Show 5 quoted lines
> - replace tabs with appropriate number of spaces
> - minor tweaks to code formatting
> ---
>  contrib/fast-import/git-p4 |   71 +++++++++++++++++++++-----------------------
>  1 files changed, 34 insertions(+), 37 deletions(-)

Sorry, but in git codebase, tabs are 8-place indent by definition, and I don't see much merit in this patch, other than being religious about somebody else's coding style, which would matter only if we are trying to get this included in "batteries included" set shipped with Python distribution, perhaps.

A downside is that this patch will make life harder for people with private patches to git-p4 that they haven't shared with us.

Previous: Andrew GarberNext: Junio C Hamano
Message 2 of 5 in “git-p4: correct indenting and formatting”
  1. git-p4: correct indenting and formattingAndrew Garber, Jan 12, 2011
  2. Junio C HamanoJan 12, 2011
  3. Junio C HamanoJan 12, 2011
  4. Junio C HamanoJan 12, 2011
  5. Andrew GarberJan 12, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.