From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 12 Jan 2011 08:45:00 GMT
Subject: Re: [PATCH] git-p4: correct indenting and formatting
Message-ID: <7vsjwy33zn.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1294808703-1848-1-git-send-email-andrew@andrewgarber.com>

Andrew Garber <andrew@andrewgarber.com> writes:

> - replace tabs with appropriate number of spaces
> - minor tweaks to code formatting
> ---
>  contrib/fast-import/git-p4 |   71 +++++++++++++++++++++-----------------------
>  1 files changed, 34 insertions(+), 37 deletions(-)

Sorry, but in git codebase, tabs are 8-place indent by definition, and I
don't see much merit in this patch, other than being religious about
somebody else's coding style, which would matter only if we are trying to
get this included in "batteries included" set shipped with Python
distribution, perhaps.

A downside is that this patch will make life harder for people with
private patches to git-p4 that they haven't shared with us.