git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] Documentation: explain how to check for patch corruption

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 15, 2011, 04:53 UTC
Message-ID
<7vsjtkdsij.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20110415022401.GC19829@elie>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 33 quoted lines
> SubmittingPatches has some excellent advice about how to check a patch
> for corruption before sending it off.  Move it to the format-patch
> manual so it can be installed with git's documentation for use by
> people not necessarily interested in the git project's practices.
>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
>  Documentation/SubmittingPatches    |   58 ++++++++---------------------------
>  Documentation/git-format-patch.txt |   46 ++++++++++++++++++++++++++++
>  2 files changed, 60 insertions(+), 44 deletions(-)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index c6a5032..20b4101 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -344,50 +344,20 @@ MUA specific hints
>  
>  Some of patches I receive or pick up from the list share common
>  patterns of breakage.  Please make sure your MUA is set up
> +properly not to corrupt whitespaces.
> +
> +See the DISCUSSION section of git-format-patch(1) for hints on
> +checking your patch by mailing it to yourself and applying with
> +git-am(1).
> +
> +While you are at it, check the resulting commit log message from
> +a trial run of applying the patch.  If what is in the resulting
> +commit is not exactly what you would want to see, it is very
> +likely that your maintainer would end up hand editing the log
> +message when he applies your patch.  Things like "Hi, this is my
> +first patch.\n", if you really want to put in the patch e-mail,
> +should come after the three-dash line that signals the end of the
> +commit message.
Perhaps the last paragraph can also go, as a copy of it now is in git-am(1)?
Show 10 quoted lines
> diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt
> index a4a9813..5c60418 100644
> --- a/Documentation/git-format-patch.txt
> +++ b/Documentation/git-format-patch.txt
> @@ -286,6 +286,52 @@ title is likely to be different from the subject
> +One way to test if your MUA is set up correctly is:
> +
> +* Send the patch to yourself, exactly the way you would, except
> +  with To: and Cc: lines that do not contain the list and
> +  maintainer address.

... "except for removing other people from To: and Cc: lines to avoid spamming them with your test"?

Previous: Jonathan NiederNext: Jonathan Nieder
Message 13 of 26 in “remove doubled words, e.g., s/to to/to/, and fix related typos”
  1. remove doubled words, e.g., s/to to/to/, and fix related typosJim Meyering, Apr 13, 2011
  2. Drew NorthupApr 13, 2011
  3. Jim MeyeringApr 13, 2011
  4. Documentation/format-patch: summarize patch-sending workflowJonathan Nieder, Apr 13, 2011
  5. Junio C HamanoApr 13, 2011
  6. Documentation: summarize how format-patch output is consumedJonathan Nieder, Apr 14, 2011
  7. Junio C HamanoApr 14, 2011
  8. 0/5 Documentation/format-patch: more hints on submitting patchesJonathan Nieder, Apr 15, 2011
  9. 1/5 Documentation: describe the format of messages with inline patchesJonathan Nieder, Apr 15, 2011
  10. Drew NorthupApr 15, 2011
  11. Junio C HamanoApr 15, 2011
  12. 2/5 Documentation: explain how to check for patch corruptionJonathan Nieder, Apr 15, 2011
  13. Junio C HamanoApr 15, 2011
  14. Jonathan NiederApr 15, 2011
  15. 3/5 Documentation: hints for sending patches inline with ThunderbirdJonathan Nieder, Apr 15, 2011
  16. 4/5 Documentation: publicize KMail hints for sending patches inlineJonathan Nieder, Apr 15, 2011
  17. Michele BallabioApr 17, 2011
  18. 5/5 Documentation: publicize hints for sending patches with GMailJonathan Nieder, Apr 15, 2011
  19. 6/5 Documentation/format-patch: suggest Toggle Word Wrap add-on for ThunderbirdJohannes Sixt, Apr 15, 2011
  20. Junio C HamanoApr 15, 2011
  21. Michael J GruberApr 15, 2011
  22. Junio C HamanoApr 15, 2011
  23. Jonathan NiederApr 15, 2011
  24. 6/5 Documentation/format-patch: suggest Toggle Word Wrap add-on for ThunderbirdJohannes Sixt, Apr 18, 2011
  25. Jakub NarebskiApr 13, 2011
  26. Junio C HamanoApr 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.