git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/5] Documentation: explain how to check for patch corruption

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Apr 15, 2011, 06:17 UTC
Message-ID
<20110415061758.GA20441@elie>
In-Reply-To
<7vsjtkdsij.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>> +++ b/Documentation/SubmittingPatches
[...]
>> +While you are at it, check the resulting commit log message from
>> +a trial run of applying the patch.  If what is in the resulting
[...]
> Perhaps the last paragraph can also go, as a copy of it now is in git-am(1)?

Yes, good idea. I wanted to keep a reminder to look over the resulting commit (and especially its log message), but this section is definitely not the place.

Show 10 quoted lines
>> +++ b/Documentation/git-format-patch.txt
>> @@ -286,6 +286,52 @@ title is likely to be different from the subject
>> +One way to test if your MUA is set up correctly is:
>> +
>> +* Send the patch to yourself, exactly the way you would, except
>> +  with To: and Cc: lines that do not contain the list and
>> +  maintainer address.
>
> ... "except for removing other people from To: and Cc: lines to avoid
> spamming them with your test"?

Yes, that is much clearer. If you'd like, I can collect other corrections and read it over again myself to resend tomorrow.

Previous: Junio C HamanoNext: Jonathan Nieder
Message 14 of 26 in “remove doubled words, e.g., s/to to/to/, and fix related typos”
  1. remove doubled words, e.g., s/to to/to/, and fix related typosJim Meyering, Apr 13, 2011
  2. Drew NorthupApr 13, 2011
  3. Jim MeyeringApr 13, 2011
  4. Documentation/format-patch: summarize patch-sending workflowJonathan Nieder, Apr 13, 2011
  5. Junio C HamanoApr 13, 2011
  6. Documentation: summarize how format-patch output is consumedJonathan Nieder, Apr 14, 2011
  7. Junio C HamanoApr 14, 2011
  8. 0/5 Documentation/format-patch: more hints on submitting patchesJonathan Nieder, Apr 15, 2011
  9. 1/5 Documentation: describe the format of messages with inline patchesJonathan Nieder, Apr 15, 2011
  10. Drew NorthupApr 15, 2011
  11. Junio C HamanoApr 15, 2011
  12. 2/5 Documentation: explain how to check for patch corruptionJonathan Nieder, Apr 15, 2011
  13. Junio C HamanoApr 15, 2011
  14. Jonathan NiederApr 15, 2011
  15. 3/5 Documentation: hints for sending patches inline with ThunderbirdJonathan Nieder, Apr 15, 2011
  16. 4/5 Documentation: publicize KMail hints for sending patches inlineJonathan Nieder, Apr 15, 2011
  17. Michele BallabioApr 17, 2011
  18. 5/5 Documentation: publicize hints for sending patches with GMailJonathan Nieder, Apr 15, 2011
  19. 6/5 Documentation/format-patch: suggest Toggle Word Wrap add-on for ThunderbirdJohannes Sixt, Apr 15, 2011
  20. Junio C HamanoApr 15, 2011
  21. Michael J GruberApr 15, 2011
  22. Junio C HamanoApr 15, 2011
  23. Jonathan NiederApr 15, 2011
  24. 6/5 Documentation/format-patch: suggest Toggle Word Wrap add-on for ThunderbirdJohannes Sixt, Apr 18, 2011
  25. Jakub NarebskiApr 13, 2011
  26. Junio C HamanoApr 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.