Re: [PATCH v2 00/12] Pulling signed/annotated tags
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 8, 2011, 05:10 UTC
- Message-ID
- <7vsjlzyza7.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CA+55aFxVsgNjGv2zAGR1VK34uG59+euJec_3i9JNyQ0VUdjyeA@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> writes:
Show 11 quoted lines
> On Mon, Nov 7, 2011 at 7:00 PM, Junio C Hamano <gitster@pobox.com> wrote: >> This is a re-roll of the fourth iteration. > > Ok, this all looks fine to me. > > Clean series, and everything looks fine. > > The one thing I wondered about is what happens when you merge two > signed tags. Maybe I read the patch wrong, but it *looks* to me like > the code just appends them all together with nothing in between. Is it > still parseable?
Eek.
The mergetag stuff is a dump of "cat-file tag" so if you have a line that begins with "object " the parsing side (which does not exist yet) would have trouble. We would need to devise e.g. adding number of lines at the beginning, or something.