From: Junio C Hamano Date: Tue, 08 Nov 2011 05:10:56 GMT Subject: Re: [PATCH v2 00/12] Pulling signed/annotated tags Message-ID: <7vsjlzyza7.fsf@alter.siamese.dyndns.org> In-Reply-To: Linus Torvalds writes: > On Mon, Nov 7, 2011 at 7:00 PM, Junio C Hamano wrote: >> This is a re-roll of the fourth iteration. > > Ok, this all looks fine to me. > > Clean series, and everything looks fine. > > The one thing I wondered about is what happens when you merge two > signed tags. Maybe I read the patch wrong, but it *looks* to me like > the code just appends them all together with nothing in between. Is it > still parseable? Eek. The mergetag stuff is a dump of "cat-file tag" so if you have a line that begins with "object " the parsing side (which does not exist yet) would have trouble. We would need to devise e.g. adding number of lines at the beginning, or something.