Re: [PATCH 1/5] gitweb: Option for filling only specified info in fill_project_list_info

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 10, 2012, 19:49 UTC
Message-ID: <7vsjiipiyu.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201202101917.52908.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

> If @fill_only is empty, it means for fill_project_list_info to fill
> all the data, if it is not empty it means that those fields needs to
> be filled.

That is exactly what I am questioning. Do you need "I need all these fields to be present" and "I will fill these other fields" (which is what @fill_only is about, no?) that is different from the former?

Show 13 quoted lines

> The code of fill_project_list_info goes like this
>
>   if (do we need to fill 'age' or 'age_string'?) {
>     fill 'age' and 'age_string'
>   }
>   if (do we need to fill 'desc_long' or 'descr'?) {
>     fill 'descr_long' and 'descr'
>   }
>   if (we are interested in 'ctags' &&
>       do we need to fill 'ctags'?) {
>     fill 'ctags'
>   }
>   ...

Exactly. Why do you need @fill_only at all? If you are interested in ctags and you want to make sure ctags is available, the question you want to ask the helper function is "Does the project structure already have ctags field?". Why does the helper function needs to know anything else?