Re: [PATCH 1/5] gitweb: Option for filling only specified info in fill_project_list_info

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 10, 2012, 21:44 UTC
Message-ID: <7vobt6nz31.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201202102230.13193.jnareb@gmail.com>

Jakub Narebski <jnareb@gmail.com> writes:

Show 15 quoted lines

>> Exactly.  Why do you need @fill_only at all?  If you are interested in
>> ctags and you want to make sure ctags is available, the question you want
>> to ask the helper function is "Does the project structure already have
>> ctags field?".  Why does the helper function needs to know anything else?
>
> It is to support incremental filling of project info.  The code is to
> go like this:
>
>   create
>   filter
>   fill part
>   filter
>   fill rest
>
> We need @fill_only for the "fill part".

Again, why?

> As filling project info is
> potentially expensive (especially the 'age' field),

So you wouldn't say "I am interested in 'age' field" but show interest in, and fill, cheaper fields in the earlier "fill" calls, and then...

> doing it on narrowed
> (filtered) list of project is a performance win.

... you drop uninteresting projects by using the partially filled information, and show interest in more expensive 'age' in the later round for surviving projects.

It still does not explain why you need @fill_only. Hrm...