Re: [PATCH] t9010: Open backflow FIFO once to work around kernel race condition
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 26, 2012, 22:58 UTC
- Message-ID
- <7vsjdh8yu8.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120626224053.GA7155@burratino>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 10 quoted lines
> Hi, > > Quick first impressions: > > Anders Kaseorg wrote: > >> Sidestep this problem by opening the backflow FIFO once for >> read+write. > > Is that portable?
If you mean [n]<>word, it probably is, even though it is somewhat unusual and I wouldn't be surprised if implementations get wrong.
>> Also, replace the stream FIFO with a shell pipe so we >> don’t have to do manual process management. > > Doesn't this mean we wouldn't notice if test-svn-fe crashes?
Very good point.