Re: [PATCH] t9010: Open backflow FIFO once to work around kernel race condition
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jun 26, 2012, 22:40 UTC
- Message-ID
- <20120626224053.GA7155@burratino>
- In-Reply-To
- <1340749806-22734-1-git-send-email-andersk@mit.edu>
Hi,
Quick first impressions:
Anders Kaseorg wrote:
> Sidestep this problem by opening the backflow FIFO once for > read+write.
Is that portable?
> Also, replace the stream FIFO with a shell pipe so we > don’t have to do manual process management.
Doesn't this mean we wouldn't notice if test-svn-fe crashes?
Maybe it would be simpler to make test-svn-fe launch fast-import as a child, avoiding the fifos altogether.
Thanks again for tracking this down, by the way. Jonathan