Re: [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2012, 22:35 UTC
Message-ID: <7vsjbfc1q7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120821214538.GA4879@dcvr.yhbt.net>

Eric Wong <normalperson@yhbt.net> writes:

Show 13 quoted lines

> Robert Luberda <robert@debian.org> wrote:
>> I have been quite a busy recently, so it took me longer that I thought.
>
> No worries, thanks for following up.
>
>> It was quite hard for me to think some sensible option name, and finally
>> have chosen --trim-svn-log (svn.trimsvnlog as config key name). Please
>> let me know if such name is ok for you. If not, I'll try to find a
>> different one (but as I wrote I'm not really good at giving names to
>> options/functions/variables, etc. :()
>
> I think having "svn" in "svn.trimsvnlog" twice is redundant and not ideal.
> Perhaps just --trim-log and svn.trimlog?

Do we ever want to trim "our" log when relaying the Git commits back to subversion? Having "svn" in "trimsvnlog" makes it clear that the logs from subversion side is getting trimmed.

> Default behavior should not change, especially not without warning.

Makes sense.