Re: [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id
- From
- Eric Wong <normalperson@yhbt.net>
- Date
- Aug 1, 2012, 21:43 UTC
- Message-ID
- <20120801214318.GA10384@dcvr.yhbt.net>
- In-Reply-To
- <1343856197-6393-1-git-send-email-robert@debian.org>
Robert Luberda <robert@debian.org> wrote:
Show 10 quoted lines
> While importing changes from SVN by `git svn fetch' strip any > white spaces from beginnings and endings of SVN commit messages > and skip adding a new line character before `git-svn-id:' > line in case the commit message ends with another pseudo-header > (like From:, Signed-off-by: or Change-Id:, etc.). > > This patch allows one to use gerrit code review system on git-svn-managed > repositories. gerrit expects its `Change-Id:' header to appear in the > last paragraph of commit message and `git-svn-id:' following a new > line character was breaking this expectation.
I've long wanted to change this, but it breaks compatibility if folks are importing from the same repo, sharing changes and one upgrades git-svn.
How about making this optional and configurable at init/clone time?