Re: [PATCH] Revert "remote-hg: update bookmarks when pulling"

From: Junio C Hamano <gitster@pobox.com>
Date: May 16, 2013, 23:14 UTC
Message-ID: <7vsj1m34bj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s3HKgWE=8SU+aBMBWzwe-fQ8Rjf0yGmGQxcdedhYCNJmQ@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 24 quoted lines

> On Thu, May 16, 2013 at 1:16 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>> This reverts commit 24317ef32ac3111ed00792f9b2921dc19dd28fe2.
>>>>
>>>> Different versions of Mercurial have different arguments for
>>>> bookmarks.updatefromremote(), while it should be possible to call the
>>>> right function with the right arguments depending on the version, it's
>>>> safer to restore the old behavior for now.
>>>>
>>>> Reported by Rodney Lorrimar.
>>>>
>>>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>>>> ---
>>>>
>>>> Intended for master (v1.8.3).
>>>
>>> Hmm, is this the one we merged yesterday?
>>
>> Just double-checking.
>
> Yes.

OK.  Thanks for keeping an eye on real user reports.

Please relay our thanks to Rodney as well.