git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Revert "remote-hg: update bookmarks when pulling"

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
May 16, 2013, 12:43 UTC
Message-ID
<1368708195-1044-1-git-send-email-felipe.contreras@gmail.com>
This reverts commit 24317ef32ac3111ed00792f9b2921dc19dd28fe2.

Different versions of Mercurial have different arguments for bookmarks.updatefromremote(), while it should be possible to call the right function with the right arguments depending on the version, it's safer to restore the old behavior for now.

Reported by Rodney Lorrimar.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
Intended for master (v1.8.3).
 contrib/remote-helpers/git-remote-hg | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index dc276af..beb864b 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -363,9 +363,6 @@ def get_repo(url, alias):
                 die('Repository error')
             repo.pull(peer, heads=None, force=True)
 
-        rb = peer.listkeys('bookmarks')
-        bookmarks.updatefromremote(myui, repo, rb, url)
-
     return repo
 
 def rev_to_mark(rev):
-- 
1.8.3.rc2.542.g24820ba
Next: Junio C Hamano
Message 1 of 6 in “Revert "remote-hg: update bookmarks when pulling"”
  1. Revert "remote-hg: update bookmarks when pulling"Felipe Contreras, May 16, 2013
  2. Junio C HamanoMay 16, 2013
  3. Junio C HamanoMay 16, 2013
  4. Felipe ContrerasMay 16, 2013
  5. Junio C HamanoMay 16, 2013
  6. Junio C HamanoMay 16, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.