git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH gitweb] Visually indicating patch size with horizontal bars

From
Junio C Hamano <junkio@cox.net>
Date
Oct 28, 2005, 03:52 UTC
Message-ID
<7vr7a6z4bc.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.64.0510271933140.4664@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
> Well, if you do full copy detection (and break detection), then 
> git-diff-tree will actually have effectively calculated the size of the 
> diff of each file. It just doesn't print them (well, it does a percentage 
> for the renames/copies).

Unbroken in-place edit would never go through diffcore-rename, so that is a gross overstatement.

But we could if we wanted to. I do not know how useful it would be, but if somebody wants to do it, I think the best strategy is to do as a separate diffcore backend that comes after diffcore_rename() runs, and do the similarity estimator only on filepairs that rename/copy did not touch.

Previous: Linus TorvaldsNext: Linus Torvalds
Message 12 of 27 in “Visually indicating patch size with horizontal bars”
  1. Visually indicating patch size with horizontal barsChris Shoemaker, Oct 27, 2005
  2. Junio C HamanoOct 27, 2005
  3. Chris ShoemakerOct 27, 2005
  4. Linus TorvaldsOct 28, 2005
  5. Chris ShoemakerOct 28, 2005
  6. Martin LanghoffOct 28, 2005
  7. H. Peter AnvinOct 28, 2005
  8. Andreas EricssonOct 28, 2005
  9. Junio C HamanoOct 28, 2005
  10. Martin LanghoffOct 28, 2005
  11. Linus TorvaldsOct 28, 2005
  12. Junio C HamanoOct 28, 2005
  13. Linus TorvaldsOct 28, 2005
  14. Kay SieversOct 28, 2005
  15. Chris ShoemakerOct 28, 2005
  16. Petr BaudisNov 1, 2005
  17. Martin LanghoffNov 1, 2005
  18. Petr BaudisNov 1, 2005
  19. Andreas EricssonNov 2, 2005
  20. Johannes SchindelinNov 2, 2005
  21. Andreas EricssonNov 2, 2005
  22. Johannes SchindelinNov 2, 2005
  23. Chris ShoemakerNov 2, 2005
  24. Kay SieversNov 2, 2005
  25. Petr BaudisDec 5, 2005
  26. Chris ShoemakerDec 5, 2005
  27. Josef WeidendorferOct 28, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.