git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH gitweb] Visually indicating patch size with horizontal bars

From
CSChris Shoemaker <c.shoemaker@cox.net>
Date
Oct 28, 2005, 02:38 UTC
Message-ID
<20051028023833.GA19939@pe.Belkin>
In-Reply-To
<20051028015642.GA31822@vrfy.org>
On Fri, Oct 28, 2005 at 03:56:42AM +0200, Kay Sievers wrote:
Show 8 quoted lines
> On Thu, Oct 27, 2005 at 04:39:45PM -0400, Chris Shoemaker wrote:
> > 
> > I really like gitweb (thanks Kay!), but I thought it would be nice to
> > have a visual indication of patch size.  I found this helpful when
> > scanning though the shortlogs.
> 
> This looks nice, but if the patch size tells you something important,
> your commit subjects are probably too short or wrong. :)

Yeah, some people write lousy commit subjects. But me? Nooo, /never/. :)

> You may try to use CSS instead of an embedded picture to draw the bar,
> just like the RSS logo in the footer, which is simple CSS rendered in the
> browser.

I'll look into that, but the cost wasn't in the image; it was in the width calculation.

Here's a side-by-side comparison.  Open two browser tabs and flip between them:

http://www.codesifter.com/cgi-bin/gitweb-difftreeP.cgi?p=git.git;a=shortlog http://www.codesifter.com/cgi-bin/gitweb-difftreeNames.cgi?p=git.git;a=shortlog

I've used a project you all are familar with, and that has more than two files. The first page uses 'git-diff-tree -p $hash|wc -l'. The second page uses 'git-diff-tree -r --name-only|wc -l'. (Oh and I have a merge indicator now.)

How do they compare for showing damage-potential? I think they both do a reasonable job. I think the full patch diff is a bit better, but it does cost.

-chris
Previous: Kay SieversNext: Petr Baudis
Message 15 of 27 in “Visually indicating patch size with horizontal bars”
  1. Visually indicating patch size with horizontal barsChris Shoemaker, Oct 27, 2005
  2. Junio C HamanoOct 27, 2005
  3. Chris ShoemakerOct 27, 2005
  4. Linus TorvaldsOct 28, 2005
  5. Chris ShoemakerOct 28, 2005
  6. Martin LanghoffOct 28, 2005
  7. H. Peter AnvinOct 28, 2005
  8. Andreas EricssonOct 28, 2005
  9. Junio C HamanoOct 28, 2005
  10. Martin LanghoffOct 28, 2005
  11. Linus TorvaldsOct 28, 2005
  12. Junio C HamanoOct 28, 2005
  13. Linus TorvaldsOct 28, 2005
  14. Kay SieversOct 28, 2005
  15. Chris ShoemakerOct 28, 2005
  16. Petr BaudisNov 1, 2005
  17. Martin LanghoffNov 1, 2005
  18. Petr BaudisNov 1, 2005
  19. Andreas EricssonNov 2, 2005
  20. Johannes SchindelinNov 2, 2005
  21. Andreas EricssonNov 2, 2005
  22. Johannes SchindelinNov 2, 2005
  23. Chris ShoemakerNov 2, 2005
  24. Kay SieversNov 2, 2005
  25. Petr BaudisDec 5, 2005
  26. Chris ShoemakerDec 5, 2005
  27. Josef WeidendorferOct 28, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.