Re: [PATCH 07/12] Git.pm: Better error handling

From: Junio C Hamano <junkio@cox.net>
Date: Jun 25, 2006, 01:30 UTC
Message-ID: <7vr71erphz.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060624131731.GU21864@pasky.or.cz>

Petr Baudis <pasky@suse.cz> writes:

Show 17 quoted lines

>> --------------------------------
>> 
>> (cd perl && /usr/bin/perl Makefile.PL \
>>                 PREFIX="/home/junio/git-test" \
>>                 DEFINE="-O2 -Wall -Wdeclaration-after-statement
>>                 -g -DSHA1_HEADER='<openssl/sha.h>'
>>                 -DGIT_VERSION=\\\"1.4.1.rc1.gab0df\\\"" \
>>                 LIBS="libgit.a xdiff/lib.a -lz  -lcrypto")
>> Unrecognized argument in LIBS ignored: 'libgit.a'
>> Unrecognized argument in LIBS ignored: 'xdiff/lib.a'
>> 
>> Do you need to pass LIBS, and if so maybe this is not a way
>> Makefile.PL expects it to be passed perhaps?
>
> It is harmless, but this should fix it:
>
> Signed-off-by: Petr Baudis <pasky@suse.cz>

Applied the "EXTLIBS" change in the message. I did the same "clean twice" change last night. Also I will apply the "PERL_DEFINES_SQ" change as well. Hopefully this would make things buildable for more people.

Thanks.