Re: [PATCH 01/12] Introduce Git.pm (v4)

From: Junio C Hamano <junkio@cox.net>
Date: Jun 25, 2006, 03:12 UTC
Message-ID: <7vr71eorlw.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20060624130234.GT21864@pasky.or.cz>

ePetr Baudis <pasky@suse.cz> writes:

Show 12 quoted lines

>> Is there a way from the environment to override this behaviour,
>> so that we can run the tests properly?  I think PERL5LIB and
>> PERLLIB are defeated by having -I there (that's why I said I
>> liked what Fredrik did with his Python script, which appends the
>> final installed location to the search path).  I think unshift
>> into @INC by hand (i.e. without even using use lib "$path")
>> would do what we want, but I feel that is a bit too ugly just 
>> for the testing X-<.
>
> PERL5LIB and use lib at the same time works for me. Anyway, with the
> second patch I've sent things should work well even if you don't have
> Git.pm installed anywhere yet.

Sorry, I am not sure it "works for me" -- which one take precedence for this?

	$ head -n 2 script.perl
        #!/usr/bin/perl -w -I /path/a
        use lib "/path/b";
        $ ./script.perl ;# invocation #1
        $ PERL5LIB=/path/c ./script.perl ;# invocation #2

Precedence between the in-script -I and "use lib" are irrelevant, but unless PERL5LIB takes precedence and the invocation #2 takes Git.pm from /path/c my previous patch to make sure test uses freshly built one does not work.

Show 17 quoted lines

>> diff --git a/perl/Makefile.PL b/perl/Makefile.PL
>> index 54e8b20..92c140d 100644
>> --- a/perl/Makefile.PL
>> +++ b/perl/Makefile.PL
>> @@ -3,7 +3,7 @@ use ExtUtils::MakeMaker;
>>  sub MY::postamble {
>>  	return <<'MAKE_FRAG';
>>  instlibdir:
>> -	@echo $(INSTALLSITELIB)
>> +	@echo $(INSTALLSITEARCH)
>>  
>>  MAKE_FRAG
>>  }
>
> Oh, yes; that line came from the time when we had no .xs yet. It is not
> visible here since both arch-specific and non-arch-specific libraries
> get installed to ~/lib.

OK.  Thanks.