Re: [PATCH] git blame --progress
- From
Junio C Hamano <junkio@cox.net>
- Date
- Jan 29, 2007, 19:06 UTC
- Message-ID
- <7vr6td7iv2.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <20070129181207.GA29451@moooo.ath.cx>
Matthias Lederhofer <matled@gmx.net> writes:
Show 12 quoted lines
> Junio C Hamano <junkio@cox.net> wrote: >> With --progress option, the command shows a fairly useless but >> amusing eye-candy while making the user wait. > > Looks nice :) It makes it much more comfortable to wait for the real > output. Perhaps there should be a config option to enable the > eye-candy when git-blame is run on a terminal (e.g. (configoption && > stdout is a tty && stderr is a tty) || --progress)? Typing --progress > is annoying. > > I also noticed that git-blame with --progress is slowed down a bit by > the terminal here; the output on stderr was ~400kb.
Easy, that was not a serious patch meant for inclusion.
If somebody wants to polish it up and re-submit that is fine by me. It might be interesting to add colors, make it less dependent on ANSI terminal control, and handle half-dots more intelligently.