Re: [PATCH 2/2] Define a few built-in attribute rules.

From: Junio C Hamano <junkio@cox.net>
Date: Apr 15, 2007, 02:04 UTC
Message-ID: <7vr6qm5r73.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0704141839030.5473@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

Show 19 quoted lines

> On Sat, 14 Apr 2007, Junio C Hamano wrote:
>>
>> This adds an obviously sane pair of default attribute rules as built-ins.
>
> I'm not sure.
>
>> +	"[attr]binary !diff !crlf",
>> +	"* diff crlf",
>
> Why would 
>
> 	* diff crlf
>
> be "obviously sane"?
>
> In fact, I'd call it obviously insane.
>
> We do *not* want to default crlf to all files. We want the default to be 
> "automatic crlf depending on content".

You do not have to worry.

That's how "crlf" is defined. Paths you explicitly say !crlf will _not_ go through the existing core.autocrlf mechanism.

"* crlf" just says, by default everybody is subject to core.autocrlf, and on sane platforms, core.autocrlf is by default off, hence you will not get LF <-> CRLF applied.