Re: [PATCH] Fix 'crlf' attribute semantics.

From: Raimund Bauer <ray007@gmx.net>
Date: Apr 16, 2007, 06:21 UTC
Message-ID: <1176704470.5966.16.camel@localhost>
In-Reply-To: <7vd52519vj.fsf@assigned-by-dhcp.cox.net>

On Sun, 2007-04-15 at 16:44 -0700, Junio C Hamano wrote:

Show 7 quoted lines

> > This change means there is no way to enable the automatic heuristics for a
> > specific pattern once it has been disable for a more generic pattern. Would it
> > make sense to make the attributes more than simply boolean?
> 
> I do not think that is a problem in practice.  Do not set
> something to "false" explicitly with a generic pattern, if you
> might want to override it.

I also don't think it's a problem, but I think it would generally be a good idea to have values for attributes. So you can say

crlf=yes|no|auto diff=yes|no|my-xml-diff|... merge=3way|...

In the yes/no case we could keep the existing syntax on just add the attribute=othervalue for those that need more than a boolean decision.

-- 
best regards

  Ray