Re: [PATCH] Don't add To: recipients to the Cc: header
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 20, 2007, 07:52 UTC
- Message-ID
- <7vr6ill5f1.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1195470026-7389-1-git-send-email-ask@develooper.com>
Ask Bjørn Hansen <ask@develooper.com> writes:
Show 24 quoted lines
> Signed-off-by: Ask Bjørn Hansen <ask@develooper.com>
> ---
> git-send-email.perl | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 65620ab..530b456 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -557,8 +557,11 @@ sub sanitize_address
> sub send_message
> {
> my @recipients = unique_email_list(@to);
> - @cc = (map { sanitize_address($_) } @cc);
> + @cc = (grep { my $cc = extract_valid_address($_);
> + not grep { $cc eq $_ } @recipients
> + }
> + map { sanitize_address($_) }
> + @cc);
> my $to = join (",\n\t", @recipients);
> @recipients = unique_email_list(@recipients,@cc,@bcclist);
> @recipients = (map { extract_valid_address($_) } @recipients);
> --
> 1.5.3.5.561.g140dHow did you prepare and send this patch?
I see 7 preimage lines and 11 postimage lines, although the hunk header claims otherwise.
Did you edit the patch in Emacs diff mode or something?