Re: [PATCH] Don't add To: recipients to the Cc: header

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 20, 2007, 19:04 UTC
Message-ID: <7v8x4slovk.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <7A3DDFA5-085D-4D92-BE96-A405FF1FB029@develooper.com>

Ask Bjørn Hansen <ask@develooper.com> writes:

Show 13 quoted lines

> On Nov 19, 2007, at 23:52, Junio C Hamano wrote:
>
>> How did you prepare and send this patch?
>
> git format-patch + tweak in emacs.
>
>> I see 7 preimage lines and 11 postimage lines, although the hunk
>> header claims otherwise.
>>
>> Did you edit the patch in Emacs diff mode or something?
>
> Indeed!  I take it you've seen that particular way of botching it
> before.  :-)

Yes and a heavy advocate of Emacs on this list wanted to get a breakage example out of me which I forgot to supply but now we have it. Unfortunately I do not offhand recall who it was.

Show 6 quoted lines

> When I was about to send the patch I realized I had added whitespace
> at the end of one of the lines.  Ironically then I ended up just
> sending the messed up patch because I couldn't apply it to my working
> copy after doing a reset.  Being a new git user I convinced myself
> that I had messed up the reset rather than the patch.  Doh.  My
> apologies!   A new patch should be on the list momentarily.

Oops, forgot to say "no need to resend". I asked only because I wanted an independent datapoint for Emacs diff mode breakage.