Re: [PATCH] Define a version of lstat(2) with posix semantics
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 19, 2009, 22:08 UTC
- Message-ID
- <7vr60t6u8n.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <alpine.DEB.1.00.0903191155300.10279@pacific.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 17 quoted lines
> Hi, > > On Thu, 19 Mar 2009, Alex Riesen wrote: > >> So that Cygwin port can continue work around its supporting >> library and get access to its faked file attributes. >> >> Signed-off-by: Alex Riesen <raa.lkml@gmail.com> >> --- > > [patch not inlined: therefore you'll have to guess what I am referring to] > > It seems quite wrong to define something for other platforms when only > Cygwin is affected. > > I'd rather just disable WIN32_STAT for Cygwin, because otherwise, we will > keep running into issues.
I am inclined to agree with this.
Back when Cygwin was the only choice, it was a way to bring benefit of git to folks who have to work on Windows, but with the recent advances in msysgit, probably Cygwin port should return to a role more in line with the overall Cygwin theme of bringing the more POSIXy sanity into Windows world. I personally see a Cygwin port as a vehicle for people who care about having a POSIXly-correct world where files have executable bits and lines are terminated with LF on Windows. If you want to have a system that is closer to Window's world view, there is (or will be, as msysgit is still officially marked as alpha) a viable alternative, and the current "selective cheating" Cygwin port does may benefit nobody.
But I do not work on Windows myself, so please take this only as a mere uninformed opinion, nothing more.