git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-parse: fix --parse-opt --keep-dashdash --stop-at-non-option

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 7, 2010, 21:41 UTC
Message-ID
<7vr5jfrmuq.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1278427565-11057-1-git-send-email-u.kleine-koenig@pengutronix.de>
Uwe Kleine-König  <u.kleine-koenig@pengutronix.de> writes:
> The ?: operator has a lower priority than |, so the implicit associativity
> made the 6th argument of parse_options be PARSE_OPT_KEEP_DASHDASH if
> keep_dashdash was true discarding PARSE_OPT_STOP_AT_NON_OPTION and
> PARSE_OPT_SHELL_EVAL.

Wow, this is an age-old breakage dating back to 6e0800e (parse-opt: make PARSE_OPT_STOP_AT_NON_OPTION available to git rev-parse, 2009-06-14) that dates back to the very original --stop-at-non-option patch, isn't it?

I wonder if I should issue an updated maintenance release v1.6.4.5 ;-)
Thanks.
Previous: Uwe Kleine-KönigNext: Uwe Kleine-König
Message 2 of 6 in “rev-parse: fix --parse-opt --keep-dashdash --stop-at-non-option”
  1. rev-parse: fix --parse-opt --keep-dashdash --stop-at-non-optionUwe Kleine-König, Jul 6, 2010
  2. Junio C HamanoJul 7, 2010
  3. Uwe Kleine-KönigJul 8, 2010
  4. Uwe Kleine-KönigJul 8, 2010
  5. Pierre HabouzitJul 8, 2010
  6. Uwe Kleine-KönigJul 8, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.